Repository navigation
Conversation
RFC 3986 treats the scheme as case-insensitive. "HTTP://" was rejected, so follow_location failed the whole Result with Error::Unknown and never requested the target. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
|
Thanks for the PR. Rejecting an uppercase scheme in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_urlaccepted a scheme only when every character was already ina-z. RFC 3986 section 3.1 says the scheme is case-insensitive, soHTTP://andHttps://are the same schemes ashttp://andhttps://.set_follow_location(true)therefore refused a validLocation, returned a null response, and reportedError::Unknownbecause the redirect failed without settingerror.h2://and other non-alpha schemes are still rejected. Client and WebSocket constructors that compare againsthttps/wsspick upHTTPS://andWSS://through the same parser.Test plan
parse_url("HTTP://example.com/path")yields schemehttp, andh2://is still rejectedLocation: HTTP://127.0.0.1:<port>/bis followed and returns 200ParseUrlTest.VariousPatternsRedirectLocationTest.FollowsUppercaseScheme